Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate_batch returning None #63

Merged
merged 1 commit into from
Feb 14, 2023
Merged

fix: generate_batch returning None #63

merged 1 commit into from
Feb 14, 2023

Conversation

engintoklu
Copy link
Collaborator

The method Problem.generate_batch(...) was unexpectedly returning None when the keyword arguments center and stdev are provided. The reason for this erroneous behavior was a missing return statement in the code. This pull request fixes the issue by introducing the forgotten return statement.

@flukeskywalker
Copy link
Contributor

Simple enough; Approved. Flagging poetry error @Higgcz

flukeskywalker
flukeskywalker previously approved these changes Feb 5, 2023
NaturalGradient
NaturalGradient previously approved these changes Feb 5, 2023
pliskowski
pliskowski previously approved these changes Feb 6, 2023
The method `Problem.generate_batch(...)` was
unexpectedly returning `None` when the keyword
arguments `center` and `stdev` are provided.
The reason for this erroneous behavior was a
missing `return` statement in the code.
This commit fixes the issue by introducing the
forgotten `return` statement.
@codecov-commenter
Copy link

Codecov Report

Merging #63 (e4f2d0f) into master (aa57024) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   77.74%   77.73%   -0.02%     
==========================================
  Files          49       49              
  Lines        7321     7322       +1     
==========================================
  Hits         5692     5692              
- Misses       1629     1630       +1     
Impacted Files Coverage Δ
src/evotorch/core.py 74.42% <0.00%> (-0.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Higgcz Higgcz merged commit ece8c39 into master Feb 14, 2023
@Higgcz Higgcz deleted the fix/generate-batch branch February 14, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants