Fix the interface of make_I
#62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engintoklu
requested review from
Higgcz,
flukeskywalker,
NaturalGradient and
pliskowski
|
👍🏽 |
flukeskywalker
previously approved these changes
Feb 5, 2023
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 77.74% 77.86% +0.11%
==========================================
Files 49 49
Lines 7321 7329 +8
==========================================
+ Hits 5692 5707 +15
+ Misses 1629 1622 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The function `evotorch.tools.make_I` was accepting a single integer as the size indicator of the identity matrix. However, The method `Problem.make_I` was working only when the size was given as a single-element tuple. This commit makes their interfaces compatible by making isure that both will work with a single integer or with a size tuple containing a single integer. Tests are updated to verify the correctness of the revised interfaces.
Higgcz
force-pushed
the
fix/make-identity
branch
from
81beef0
to
5c7d266
Compare
Higgcz
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
evotorch.tools.make_Iwas accepting a single integer as the size indicator of the identity matrix. However, the methodProblem.make_Iwas working only when the size was given as a single-element tuple. This pull request makes their interfaces compatible by making isure that both will work with a single integer or with a size tuple containing a single integer. Tests are updated to verify the correctness of the revised interfaces.