Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Round the net charge to the nearest integer #258

Merged
merged 4 commits into from
Oct 28, 2021
Merged

ENH: Round the net charge to the nearest integer #258

merged 4 commits into from
Oct 28, 2021

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Oct 28, 2021

Ensure that the cached net charge is rounded to the nearest integer.

@BvB93 BvB93 added the enhancement New feature or request label Oct 28, 2021
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #258 (1af1d28) into master (6d2a241) will increase coverage by 0.01%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
+ Coverage   75.23%   75.24%   +0.01%     
==========================================
  Files          65       65              
  Lines        6929     6937       +8     
  Branches     1247     1248       +1     
==========================================
+ Hits         5213     5220       +7     
- Misses       1384     1385       +1     
  Partials      332      332              
Impacted Files Coverage Δ
FOX/armc/param_mapping.py 84.67% <75.00%> (-0.15%) ⬇️
FOX/armc/sanitization.py 89.92% <100.00%> (+0.02%) ⬆️
FOX/functions/charge_utils.py 86.99% <100.00%> (+0.21%) ⬆️
FOX/logger.py 83.82% <100.00%> (+0.24%) ⬆️
FOX/io/read_psf.py 79.92% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2a241...1af1d28. Read the comment docs.

@BvB93 BvB93 merged commit bbe36c7 into master Oct 28, 2021
@BvB93 BvB93 deleted the noise branch October 28, 2021 14:11
@BvB93 BvB93 added this to the 0.9.2 milestone Oct 28, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant