Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#141): Created better tests structure #142

Merged
merged 10 commits into from
Oct 7, 2024
Merged

feat(#141): Created better tests structure #142

merged 10 commits into from
Oct 7, 2024

Conversation

Hiccup-za
Copy link
Member

@Hiccup-za Hiccup-za commented Oct 7, 2024 •
edited
Loading

GitHub Issue: #141

Changes

  • Created the sqlite folder & split tests out into separate test files
  • Addressed all warnings within test files
  • Updated the README with a Testing section

Let me know what you think!

Testing

All tests:
all tests

All tests within sqlite folder:
all sqlite tests

A specific test within the sqlite folder:
specific test

@vercel Vercel
Copy link

vercel bot commented Oct 7, 2024

@Hiccup-za is attempting to deploy a commit to the Marcus Cvjeticanin Team on Vercel.

A member of the Team first needs to authorize it.

mjovanc
mjovanc reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@mjovanc mjovanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing work! I just left two comments if you can take a look at those and I will merge it.

njord/tests/sqlite/open_test.rs Outdated Show resolved Hide resolved
njord/tests/sqlite/update_test.rs Outdated Show resolved Hide resolved
@mjovanc
Copy link
Member

mjovanc commented Oct 7, 2024

Also add this to the contributors section in README.md:

[<img src="https://github.com/Hiccup-za.png?size=72" alt="Hiccup-za" width="72">](https://github.com/Hiccup-za)

@mjovanc mjovanc added this to the v0.4.0-alpha milestone Oct 7, 2024
@mjovanc mjovanc added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 7, 2024
@mjovanc mjovanc linked an issue Oct 7, 2024 that may be closed by this pull request
Create better tests structure #141
Closed
@mjovanc
Copy link
Member

mjovanc commented Oct 7, 2024 •
edited
Loading

Also, add "Testing" to the TOC in README.md.

@mjovanc mjovanc merged commit 6aafc5e into njord-rs:master Oct 7, 2024
1 of 2 checks passed
@mjovanc
Copy link
Member

mjovanc commented Oct 7, 2024

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjovanc mjovanc mjovanc left review comments

Assignees

@Hiccup-za Hiccup-za

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
v0.4.0-alpha
Development

Successfully merging this pull request may close these issues.

Create better tests structure
2 participants
@Hiccup-za @mjovanc