Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Manual Reload script with non-standard layout dir #401

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

bbenne10
Copy link
Contributor

Closes #400.

Cannot request @gmacon for review, but would appreciate his feedback.

@bbenne10 bbenne10 requested a review from Mic92 October 31, 2023 16:06
@bbenne10 bbenne10 self-assigned this Oct 31, 2023
direnvrc Outdated Show resolved Hide resolved
No longer assumes location of layout directory relative to code.
This provides color so that the user can see them in the possible wall
of text that direnv sometimes spits out.
@bbenne10
Copy link
Contributor Author

Realized that the earlier mkdir -p without a check was not gonna fly - it will print an error if the call fails.

Copy link

@gmacon gmacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

direnvrc Outdated Show resolved Hide resolved
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
@bbenne10 bbenne10 merged commit 0c68782 into master Nov 1, 2023
9 checks passed
@bbenne10 bbenne10 deleted the manual_reload_fix branch November 1, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual reloading assumes default direnv_layout_dir
3 participants