Consume Input stream instead of file in split and to-csv #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend to tick the
Hide whitespace changes
box when reviewing this PR.This PR is about making sure that
OrderedHistogramLogReader
consumes anInputStream
instead of aFile
. The change does not impact a lot of the codebase, asHistogramLogScanner
already supports reading from anInputStream
.The main advantage is that if a Java application processes a file that is compressed, the
GZIPInputStream
can be passed straight away to HdrLogProcessing instead of decompressing in a temporary file.To enable this ^ use case, the
SplitHistogramLogs
andHdrToCsv
logics are extracted to a dedicated class. This makes it possible to include HdrLogProcessing as a library, rather than only use it from the command line.