Bugfix for optional output template files (i.e. of type Union[Path, bool]) when set to False

[tclose]

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Summary

For options such as the following where an optional output file (with a template) type Union[Path, bool], where the value is set to False, the collection of outputs was failing when attempting to coerce the boolean to a File

(
    "unused",
    attr.ib(
        type=ty.Union[Path, bool],
        default=False,
        metadata={
            "argstr": "--not-used",
            "output_file_template": "out.txt",
            "help_string": "dummy output",
        },
    ),
),

This bug-fix omits these fields from the collected outputs

Checklist

• [ x ] I have added tests to cover my changes (if necessary)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.65%. Comparing base (1720ba6) to head (87cc499).
Report is 15 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
+ Coverage   83.35%   83.65%   +0.30%     
==========================================
  Files          24       24              
  Lines        4949     4986      +37     
  Branches     1411     1416       +5     
==========================================
+ Hits         4125     4171      +46     
+ Misses        816      809       -7     
+ Partials        8        6       -2     

Flag	Coverage Δ
unittests	83.65% <100.00%> (+0.30%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[effigies]

This seems to work. I agree it would be good to understand the use case for L462 and either remove or test it.

[effigies]

Is one the nested ifs redundant?