FIX: Enable fieldmapless by default in CLI #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
added a commit
that referenced
this pull request
Jan 22, 2024
2.8.1 (January 22, 2024) Bug-fix release in the 2.8.x series. Fixes doc builds and CLI support for fieldmapless workflows. Introduces support for BIDS-URIs. * FIX: Enable fieldmapless by default in CLI (#426) * FIX: Pandoc requires Texlive to render LaTeX in notebook (#427) * FIX: New test ``test_wrangler_URIs`` had the wrong oracle (#425) * ENH: Resolve BIDS-URIs (#349) * TEST: Use less confusing function name for testing CLI with --dry-run (#424) * MNT: Bump actions/download-artifact from 3 to 4 (#418) * MNT: Bump actions/upload-artifact from 3 to 4 (#417) * CI: Move PR doc build into main doc build, add texlive to build dependencies (#428)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As currently written, SyN-SDC cannot run, since we store
Falseby default, and only allowFalseto be set with--no-fmapless. Also, we were using the wrong variable; elsewhere we usefmapless, notfieldmapless.While here, I'm adding a check that the constructed workflow is not empty and giving a separate error message.