FIX: Use lsqr solver for spline fit, rerun on extreme values #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like it can be slower in some cases, but doesn't have the >30min worst case performance.
effigies
changed the title
|
@mgxd @oesteban This node is run for both ds054 and ds210 in nipreps/fmriprep#3031. This drops the ds210 runtime of the node from >2000s (when it fails to converge) to 13s. ds054 runs in 4s. I'm keeping in the rerun in case lsqr also has some edge cases, but I think it's a straight win and fixes fMRIPrep CI. |
|
Brilliant, thanks a lot.
…On Thu, Jun 8, 2023, 14:49 Chris Markiewicz ***@***.***> wrote:
@mgxd <https://github.com/mgxd> @oesteban <https://github.com/oesteban>
This node is run for both ds054 and ds210 in nipreps/fmriprep#3031
<nipreps/fmriprep#3031>. This drops the ds210
runtime of the node from >2000s to 13s. ds054 runs in 4s. I'm keeping in
the rerun in case lsqr also has some edge cases, but I think it's a
straight win and fixes fMRIPrep CI.
—
Reply to this email directly, view it on GitHub
<#366 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAESDRXSNUBBMH4H7AJMXJDXKINDHANCNFSM6AAAAAAY7N3M6U>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #365.