Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect package's properties #79

Closed
mrfatguy opened this issue Mar 22, 2024 · 5 comments · Fixed by #141
Closed

Incorrect package's properties #79

mrfatguy opened this issue Mar 22, 2024 · 5 comments · Fixed by #141
Assignees
Labels
bug Something isn't working

Comments

@mrfatguy
Copy link
Contributor

mrfatguy commented Mar 22, 2024

Please, fix incorrect package or build properties.

AS-IS (Current status)

1. Installer program

  1. Main window's title: california-49er-desktop-v1
  2. Folder created in %APPDATA%: california-49er-desktop-v1
  3. Item added to "Add/Remove programs" list: california-49er-desktop-v1

2. Installed app's desktop icon

  1. Image: Electron's default (descoped from this ticket)
  2. Title: california-49er-desktop-v1
  3. Company: Maciej Madejczyk
  4. File description: Lost dutchman mine game for desktop.
  5. File version: 0.0.3.0 (unnecessary fourth digit) // EDIT: It seems we cannot change this, as windows adds it by itself. Descoping.

3. Main game's window

  1. Title: Goldrush.

TO-BE (Expected results)

1. Installer program

  1. Main window's title: Lost Dutchman Mine
  2. Folder created in %APPDATA%: Niner Games\Lost Dutchman Mine (notice dir\subdir scheme)
  3. Item added to "Add/Remove programs" list: Lost Dutchman Mine

2. Installed app's desktop icon

  1. Image: Game logo-based (→ #115, #116 and #117)
  2. Title: Lost Dutchman Mine (without dot at the end)
  3. Company: Niner Games
  4. File description: Lost Dutchman Mine
  5. File version: 0.0.3

3. Main game's window

  1. Title: Lost Dutchman Mine

Examples

Some examples on how does it look right now.

Installed app's desktop icon

example 1

App's destination folder name

example 2

Item in the "Add/remove programs" list:

image

Main game's window

example 3

@mrfatguy mrfatguy added the bug Something isn't working label Mar 22, 2024
@MadejaMaciej
Copy link
Contributor

MadejaMaciej commented Apr 14, 2024

So after some extensive research, I would like to adjust scope of this ticket, that means getting off point 5. It seems that windows mark File version with x.y.z.a code always and automatically and there is nothing we can do about it. There is the second property tho, that shows the correct version if that suits us.

Is that okay?

This task is taking longer than I thought and is blocking me pretty strong, because of that code. @mrfatguy

@mrfatguy
Copy link
Contributor Author

If other points (1.1-1.3, 2.1-2.4 and 3.1) are completed then you can of course close this ticket as done! 🥇

@MadejaMaciej
Copy link
Contributor

Need to adjust the directory structure still, but other things are done. Will do that and close the ticket then.

@MadejaMaciej
Copy link
Contributor

Could not manage to get Folder -> subfolder to work. Can we have separate task for that, as this is not entirely a property issue? It's a builder thing I would need to debug @mrfatguy

@mrfatguy
Copy link
Contributor Author

Could not manage to get Folder -> subfolder to work. Can we have separate task for that, as this is not entirely a property issue? It's a builder thing I would need to debug @mrfatguy

Done, sir! :] #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants