Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown renderer with support for translations #56

Closed
mrfatguy opened this issue Mar 12, 2024 · 6 comments · Fixed by #104
Closed

Markdown renderer with support for translations #56

mrfatguy opened this issue Mar 12, 2024 · 6 comments · Fixed by #104
Assignees
Labels
feature New feature or request, requires business analysis in most cases

Comments

@mrfatguy
Copy link
Contributor

mrfatguy commented Mar 12, 2024

Please, implement Markdown renderer with support for translations and with some additional extensions.

In addition to #54 we need to support whole-page translations (or translation of big blocks of text), based on Markdown language, for features like credits or newspaper.

The mechanism of actually displaying credits or newspaper will be handled by a separate tickets. This ticket is for introducing Markdown renderer to our application only.

Details are given in our Wiki: Application. Translations → Translation of big blocks of text.

@mrfatguy mrfatguy added the feature New feature or request, requires business analysis in most cases label Mar 12, 2024
@mrfatguy mrfatguy added this to the Translation system milestone Mar 12, 2024
@mrfatguy mrfatguy changed the title Implement markdown renderer Implement markdown renderer with support for translations Mar 12, 2024
@mrfatguy mrfatguy changed the title Implement markdown renderer with support for translations Markdown renderer with support for translations Mar 13, 2024
@MadejaMaciej
Copy link
Contributor

@mrfatguy ticket is done, I found nice MIT license plugin with full support of markdown.

https://www.npmjs.com/package/react-markdown

You can provide translations/large blocks of code in Markdown format now

MadejaMaciej added a commit that referenced this issue Mar 24, 2024
It will handle large blocks of text.

✅ Closes: #56
@MadejaMaciej
Copy link
Contributor

P.S all tested and it works nicely.

MadejaMaciej added a commit that referenced this issue Mar 24, 2024
It will handle large blocks of text.

✅ Closes: #56
@mrfatguy
Copy link
Contributor Author

@MadejaMaciej Does it support embedding HTML code and renders it correctly?

@MadejaMaciej
Copy link
Contributor

MadejaMaciej commented Mar 24, 2024

@mrfatguy Yes but you need to escape all the ` character so use backslash before it.

@mrfatguy
Copy link
Contributor Author

OK, but HTML generally doesn't use backtick, right? So, basically speaking, this should work:

<span style="font-size: #px">Lost Dutchman Mine</span>

A tale as old as _the desert itself_.
Legend says it holds a fortune **in gold**, just _waiting to be found_!

<div style="text-align: left">Copyright (c) 2024 by Niner Games</div>

Am I correct?

@MadejaMaciej
Copy link
Contributor

sorry, I was thinking about

code

Yes it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request, requires business analysis in most cases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants