Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title is missing from web version, when it is crawled #169

Closed
mrfatguy opened this issue May 1, 2024 · 0 comments · Fixed by #174
Closed

Title is missing from web version, when it is crawled #169

mrfatguy opened this issue May 1, 2024 · 0 comments · Fixed by #174
Assignees
@MadejaMaciej
Labels
bug Something isn't working
Milestone
[0.03] Startup se...

Comments

@mrfatguy
Copy link
Contributor

mrfatguy commented May 1, 2024 •
edited

Overview

Please, add the missing <title> element the to <head> section of web version's main index.html file.

Details

The destination file (see: https://play.lostmine.cc/main_window/index.html) has <title> added element the to <head> section:

<!doctype html>
<html>
  <head>
    <meta charset="UTF-8" />
    <title>Lost Dutchman Mine</title>
    <link rel="icon" type="image/png" href="favicon.png" />
    <script defer="defer" src="../main_window/index.js"></script>
  </head>
  <body>
    <div id="root"></div>
  </body>
</html>

But the source (initial, startup) file (see: https://play.lostmine.cc/index.html), added in #113 and 987b7e42 doesn't have it:

<!DOCTYPE html>
<html lang="en">
    <head>
        <script>
            const l = window.location.href;
            const s = l.split('index.html')[0];
            window.location.href = s + 'main_window/index.html'
        </script>
        <!-- the document has no actual content; neither character encoding nor styles and scripts are needed -->
    </head>
    <body>
        <!-- no body content in case of redirect -->
    </body>
</html>

This causes that even though the web version (after executed redirect) does display the game's title correctly:

image

But, when web-crawlers or robots (like short.io) crawls https://play.lostmine.cc/, the title is missing:

image

Please, fix this by adding the missing <title> element the to <head> section of https://play.lostmine.cc/index.html file. Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MadejaMaciej MadejaMaciej

Labels
bug Something isn't working
Projects
None yet
Milestone
[0.03] Startup sequence, settings and...
Development

Successfully merging a pull request may close this issue.

fix: 🐛 Fix crawler not displaying title due to missing tag niner-games/lost-dutchman-mine
2 participants
@mrfatguy @MadejaMaciej