Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon for mac #144

Closed
MadejaMaciej opened this issue Apr 15, 2024 · 2 comments · Fixed by #145
Closed

Add favicon for mac #144

MadejaMaciej opened this issue Apr 15, 2024 · 2 comments · Fixed by #145
Assignees
Labels
feature New feature or request, requires business analysis in most cases

Comments

@MadejaMaciej
Copy link
Contributor

It has to have 512px width and height

@MadejaMaciej MadejaMaciej added the feature New feature or request, requires business analysis in most cases label Apr 15, 2024
@MadejaMaciej MadejaMaciej self-assigned this Apr 15, 2024
MadejaMaciej added a commit that referenced this issue Apr 15, 2024
MadejaMaciej added a commit that referenced this issue Apr 15, 2024
MadejaMaciej added a commit that referenced this issue Apr 15, 2024
@mrfatguy
Copy link
Contributor

mrfatguy commented Apr 15, 2024

@MadejaMaciej It seems that you have made this 512x512 icon yourself. Keep in mind that we have all the assets prepared for all the platforms, based on what Electron guide specifies.

Make sure that you have it working, as you have used .png file where Electron guide requires you to use .icns file instead.

Reopening. Close again after you verify that this truly works on MacOS, even though you have used .png file. Thanks.

@mrfatguy mrfatguy reopened this Apr 15, 2024
@MadejaMaciej
Copy link
Contributor Author

MadejaMaciej commented Apr 15, 2024

It works, png vs icn doesn't matter from a long time. Compiler just where playing tricks on me and would not compile as for windows and linux I had to use 256px one, and for mac minimal one is 512px.

@mrfatguy mrfatguy added this to the [0.00] Initial setup milestone Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request, requires business analysis in most cases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants