Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New viewport's dimensions and margins #112

Closed
mrfatguy opened this issue Mar 26, 2024 · 0 comments · Fixed by #132
Closed

New viewport's dimensions and margins #112

mrfatguy opened this issue Mar 26, 2024 · 0 comments · Fixed by #132
Assignees
Labels
feature New feature or request, requires business analysis in most cases

Comments

@mrfatguy
Copy link
Contributor

mrfatguy commented Mar 26, 2024

Most likely screen elements' dimensions are not correct and there are left and right margin missing. So, please, check currently implemented viewport of the game and introduce necessary changes:

Screen element gX, gY gW, gH aX, aY aW, aH
Notification Area 18, 0 314, 9 193, 0 3456, 98
Action Window 18, 9 314, 98 193, 98 3456, 1080
Control Panel 18, 108 314, 90 193, 1189 3456, 971

Based on these values, please, calculate a pixel ratio that will allow you to display all elements correctly in all resolutions and game window's sizes.

Such ratio should be somehow constant for the entire GUI / viewport, because starting from this ticket all the GUI's elements (like buttons, items, etc.) will be given as in this example, i.e. with values in in-game pixels and actual 4K resolution pixels.

But, please, keep in mind that due to resolution differences (as mentioned in here) pixel ratio is not constant for every pixel. Most of the pixels has 11x11 area in 4K resolutions, but there are certain lines that has 11x10 or 10x11 pixels. We do not have to support these differences, but it is good idea to keep them in mind, in case some future calculations would ended in some unexpected results.

@mrfatguy mrfatguy added the feature New feature or request, requires business analysis in most cases label Mar 26, 2024
@mrfatguy mrfatguy added this to the [0.5] Common GUI elements milestone Mar 26, 2024
MadejaMaciej added a commit that referenced this issue Apr 13, 2024
MadejaMaciej added a commit that referenced this issue Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request, requires business analysis in most cases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants