fix: correctly render partial borders (fix #1920) #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 22, 2019
Closed
Closed
pawelzwronek
pushed a commit
to pawelzwronek/html2canvas
that referenced
this pull request
Oct 13, 2019
|
I got the problem #1920 with version html2canvas 1.0.0-rc.5. Which version should I use to fix this? Thanks. |
|
@wufeng87 I was also having issues rendering the right and bottom borders with 1.0.0-rc.5, but reverting back to 1.0.0-rc.2 seems to fix it. |
|
My borders are still rendered incorrectly? Is this fixed for rc.7? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1920
Fixes #1952