Add support for ES and browser bundlers #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the following features:
The
mainfield in package.json points to'dist/npm/index.js', which is ideal for CommonJS projects, however will fail on ES/browser bundlers because of the use of the undefinedprocess.env.NODE_ENV.This PR adds the fields
moduleandbrowserto package.json, as defined here and here (module) and here (browser). Both fields point todist/html2canvas.js, which is built as UMD and will work with any format.Test plan (required)
Create a new project, use ES syntax to
importhtml2canvas, and use rollup or similar to bundle into UMD. The termprocess.env.NODE_ENVwill no longer appear in the bundled code using this PR.Closing issues
No matching issues found.