Merge bgc obc 3 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This commit is the first attempt to add a (generic) tracer to the OBC. - The tracer "gtr1" is added from the ocean_bgc module generic_CFC.F90 - It is to imitate "salt" as if it was a passive tracer.
- This update queries the obgc modules (generic_tracers) for the OBC source files and var names for each generic tracers and initializes the segment fields accoringly. - With this update the obgc tracers should NOT appear in OBC_SEGMENT_XXX_DATA in MOM parameter files (MOM_override). - The default source file name is obgc_obc.nc - The default source file var name is the generic_tracer name - These can be overriden by field_table mechanism. E.g., "namelists","ocean_mod","generic_CFC" cfc11_obc_src_field_name = salt cfc12_obc_src_field_name = salt /
- This update adds OBC reservoirs for all obgc tracers that are registered to have OBC. - This fixes restart issue with obgc tracers in test runs
Conflicts: src/core/MOM_open_boundary.F90 src/tracer/MOM_generic_tracer.F90
…cers - This introduces a time scale for updating OBC segment data for OBGC tracers by a parameter override, e.g., 1 day instead of DT via #override UPDATE_OBC_PERIOD_MAX = 86400 - Won't affect T&S or other fields , but it's easy to include any field by adding their names to the if() cycle statement
…cers
- This introduces a time scale for updating OBC segment data for OBGC
tracers by a parameter override, e.g., 1 day instead of DT via
#override UPDATE_OBC_PERIOD_MAX = 86400
- Won't affect T&S or other fields , but it's easy to include any field
by adding their names to the if() cycle statement
…extra tracers registered first on boundary
Obgc obc seg data update period
- This update along with an update to generic_tracers_utils.F90 brings in the capability to set tracer reservoir (inverse) length scales for individual obgc tracers via ocean_bgc field_table mechanism. - Tracer resevoir inverse length scales are set as before to 1.0/Lscale_in and 1.0/Lscale_out - Users should be able to specify a multiplicative factor for each obgc tracer for each IN or OUT direction in the field_table, e.g., alk_obc_lfac_in = 0.5 alk_obc_lfac_out = 0.75 - The factors are multiplied by the inverse length scales before reservoir calculations. - The default factors for all tracers are 1. - No answer changes unless non-one factors are specified in field_table
- This update along with an update to generic_tracers_utils.F90 brings
in the capability to set tracer reservoir (inverse) length scales for
individual obgc tracers via ocean_bgc field_table mechanism.
- Tracer resevoir inverse length scales are set as before to 1.0/Lscale_in and
1.0/Lscale_out
- Users should be able to specify a multiplicative factor for each obgc
tracer for each IN or OUT direction in the field_table, e.g.,
alk_obc_lfac_in = 0.5
alk_obc_lfac_out = 0.75
- The factors are multiplied by the inverse length scales before
reservoir calculations.
- The default factors for all tracers are 1.
- No answer changes unless non-one factors are specified in field_table
…scale Obgc tracer reservoir lengthscale
- This update fixes the restart issues for OBC runs if reservoir length scale is set to zero - There is still a restart issue when the reservoir length scale is non-zero even for the physical (noCOBALT) models that has to be fixed.
- Apply halo updates to h,uhr,vhr before use in tracer reservoir update
fixes the restart issue for the physical model T&S
fixes the restart issue for the BGC tracers when segment update period = DT
- There is still a restart issue for BGC tracers when segment update period > DT
- However the later restart issue is absent when tracer reservoir INPUT length scale is 0
which points to an issue in segment%tr_Reg%Tr(m)%t
- Apply halo updates to h,uhr,vhr before use in tracer reservoir update
fixes the restart issue for the physical model T&S
fixes the restart issue for the BGC tracers when segment update period = DT
- Fix the restart issue for BGC tracers when segment update period > DT
fixes the logic for setting the update time (it was not correct)
Note that DT_OBC_SEG_UPDATE_OBGC has to be an integer multiple of DT and DT_THERM !
fix restart issues with OBC experiments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a placeholder for merging to the authoritative fork.