fix restart issues with OBC experiments #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This update fixes the restart issues for OBC runs if reservoir length scale is set to zero - There is still a restart issue when the reservoir length scale is non-zero even for the physical (noCOBALT) models that has to be fixed.
- Apply halo updates to h,uhr,vhr before use in tracer reservoir update
fixes the restart issue for the physical model T&S
fixes the restart issue for the BGC tracers when segment update period = DT
- There is still a restart issue for BGC tracers when segment update period > DT
- However the later restart issue is absent when tracer reservoir INPUT length scale is 0
which points to an issue in segment%tr_Reg%Tr(m)%t
- Apply halo updates to h,uhr,vhr before use in tracer reservoir update
fixes the restart issue for the physical model T&S
fixes the restart issue for the BGC tracers when segment update period = DT
- Fix the restart issue for BGC tracers when segment update period > DT
fixes the logic for setting the update time (it was not correct)
Note that DT_OBC_SEG_UPDATE_OBGC has to be an integer multiple of DT and DT_THERM !
andrew-c-ross
pushed a commit
that referenced
this pull request
Jul 1, 2024
* mod g_tracer interface * mod g_tracer interface * Simplify g_tracer interface changes * add description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NWA OBC experiments suffer from a restart issue. There are a few bugs mixed together that were causing these and this update tries to address them. There were two basic issues; 1. A few missing halo updates causing the physical as well as obgc experiments not to reproduce
2. Bad logic for determining the update time for obgc tracers that use a segment updating period larger than DT.
Here's how to address these:
fixes the restart issue for the physical model T&S
fixes the restart issue for the BGC tracers when segment update period = DT
fixes the logic for setting the update time (it was not correct)
Note that DT_OBC_SEG_UPDATE_OBGC has to be an integer multiple of DT and DT_THERM !