New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute tests in parallel by default #3364

Merged

beatfactor merged 30 commits into nightwatchjs:main from swrdfish:feature/parallel-first

Oct 18, 2022

Member

swrdfish commented Sep 1, 2022

closes #3331

swrdfish added 2 commits

August 28, 2022 12:27


          set parallel mode as default

b684aed


          set parallel to false for test which donot need parallel execution

6961eea

swrdfish marked this pull request as draft

September 1, 2022 07:28

harshit-bs assigned swrdfish

swrdfish added 8 commits

September 4, 2022 21:02


          implement parallel execution for multiple environments

1f6ec31


          update maxworker calculation

9aac390


          bug fix, envs count 0 should not cause error

aaf9148


          fix test

97ef93a


          filter modules based on environment filters


          update connection message

a7ba0a6


          bug fix, use correct environment for child process

c3ee7ec


          refactor: filter modules before building process queue

9640a77

swrdfish requested review from beatfactor and gravityvi

September 5, 2022 14:43

swrdfish marked this pull request as ready for review

September 5, 2022 14:44

harshit-bs reviewed

View reviewed changes

lib/settings/settings.js Outdated Show resolved Hide resolved

Member

harshit-bs commented Sep 6, 2022 •

edited

Loading

@swrdfish It would be great to update the description or issue to check what is completed. Since I can't see the code for below requirement.

the number of parallels mentioned are more than the CPU cores, a warning message should be shown


          show warning if number of workers is more than cpu count

f7a606f

Member Author

swrdfish commented Sep 7, 2022

@harshit-bs made the necessary changes.

swrdfish added 3 commits

September 8, 2022 12:53


          implement suggestions


          revert tests

f9ad121


          Merge branch 'main' into feature/parallel-first

swrdfish mentioned this pull request

Enable parallel by default nightwatchjs/create-nightwatch#52

Merged

beatfactor reviewed

View reviewed changes

lib/runner/cli/nightwatch.conf.ejs Outdated Show resolved Hide resolved

beatfactor reviewed

View reviewed changes

lib/runner/cli/cli.js Outdated Show resolved Hide resolved

beatfactor reviewed

View reviewed changes

lib/settings/settings.js Show resolved Hide resolved

beatfactor reviewed

View reviewed changes

lib/transport/selenium-webdriver/index.js Outdated Show resolved Hide resolved

beatfactor reviewed

View reviewed changes

test/src/runner/testRunWithHooks.js Outdated Show resolved Hide resolved

beatfactor reviewed

View reviewed changes

Member

beatfactor left a comment

More tests are needed for the --seqential flag and for the changes to filtering.


          incorporate suggestions

894b5c9


          Merge branch 'feature/parallel-first' of github.com:swrdfish/nightwat…

9dd4dfe

…ch into feature/parallel-first

beatfactor reviewed

View reviewed changes

lib/runner/cli/argv-setup.js Show resolved Hide resolved

beatfactor reviewed

View reviewed changes

lib/runner/concurrency/index.js Outdated Show resolved Hide resolved

beatfactor reviewed

View reviewed changes

lib/settings/settings.js Show resolved Hide resolved

swrdfish added 4 commits

September 22, 2022 14:59


          refactor implementation for parallel environments

829da2f


          fix tests and refactor

08b915c


          Merge branch 'main' of github.com:nightwatchjs/nightwatch into featur…

e07a894

…e/parallel-first


          fix tests

88efc7a

gravityvi requested changes

View reviewed changes

lib/runner/concurrency/index.js Outdated Show resolved Hide resolved

lib/runner/cli/cli.js Outdated Show resolved Hide resolved

lib/runner/cli/cli.js Show resolved Hide resolved

lib/settings/settings.js Outdated Show resolved Hide resolved

swrdfish added 2 commits

October 13, 2022 15:33


          code clean up

baef719


          remove console log

b00f14d

swrdfish requested review from gravityvi and beatfactor

October 13, 2022 13:06

beatfactor reviewed

View reviewed changes

lib/runner/cli/argv-setup.js Outdated Show resolved Hide resolved


          Update lib/runner/cli/argv-setup.js

d5e0f7c

beatfactor reviewed

View reviewed changes

lib/runner/cli/cli.js Outdated Show resolved Hide resolved

beatfactor added 2 commits

October 14, 2022 14:16


          Update lib/runner/cli/cli.js

720c7d3


          Merge branch 'main' into feature/parallel-first

beatfactor reviewed

View reviewed changes

lib/runner/cli/argv-setup.js Outdated Show resolved Hide resolved


          Update lib/runner/cli/argv-setup.js

1e6030f

beatfactor reviewed

View reviewed changes

lib/runner/cli/argv-setup.js Outdated Show resolved Hide resolved


          Update lib/runner/cli/argv-setup.js

af14d42

beatfactor reviewed

View reviewed changes

lib/runner/cli/argv-setup.js Outdated Show resolved Hide resolved


          Update lib/runner/cli/argv-setup.js

def4276

beatfactor reviewed

View reviewed changes

lib/settings/settings.js Outdated Show resolved Hide resolved


          Update lib/settings/settings.js

7c09f7f

beatfactor reviewed

View reviewed changes

lib/runner/cli/nightwatch.conf.ejs Outdated Show resolved Hide resolved


          Update lib/runner/cli/nightwatch.conf.ejs

79a2a11

beatfactor merged commit 9b43e28 into nightwatchjs:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet