-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CDP Commands support (all commands in single PR) #3208
Add CDP Commands support (all commands in single PR) #3208
Conversation
…/add-cdp-commands
…/add-cdp-commands
…/add-cdp-commands
20e1c75
to
64f32ce
Compare
64f32ce
to
06f21b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need a new base class for all the CDP commands with common methods to validate the current driver
This PR is already too long, can we do this in a separate PR after getting this merged? And what are the exact requirements of the new base class, will it extend the |
I think it should be part of this PR because it will actually make it a bit shorter. It's up to you to decide what to put in the base class. |
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
features/my-new-feature
orissue/123-my-bugfix
);