Implement SSO using cookie and .config file. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I think would be good if we could have a branch from this MR so the project can support the SSO, we only need to paste the
cookiein the.configfile + thebookId. This allowed me to download books using my SSO account.Since some things changed I wouldn't expect this to be merged to master but could be kept as a separated branch so others can make use of the SSO to download books as well.
I had some troubles running the previous command, I updated it to be:
npm run safaribooksPlease let me know if there's anything you would want me to change so this can be kept as a different branch. :)
This could cover the following cases: #4 #18 #14
Thanks,
Adán