Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add support for dictionary selection, add a racist words list #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

decompil3d
Copy link
Collaborator

Hi there -- thanks for writing this. I'd like to add the option to select dictionaries of forbidden words, with the eventual goal of adding more dictionary options such as non-inclusive terms (e.g. gendered language, etc). Since some repos might have different standards they'd like to maintain regarding language, dictionaries allow that freedom.

This first step simply adds a dictionaries option, renames the existing config/blacklist.json file to dictionaries/profanity.json, and adds a new racist terms dictionary.

Please let me know if you'd like any changes to my contribution. I tried to match your code style as much as possible. Thanks!

@nickgarlis
Copy link
Owner

@decompil3d Hi, apologies for the delay, I so missed this PR.

Thanks for making this change ! It looks like a very useful feature. I was wondering if you think it would also make sense to also let users provide their own custom list in the config.yml in case they do not want to use any of the already defined lists.

I will merge your PR once I fix the failing pipelines.

@decompil3d
Copy link
Collaborator Author

Yup, definitely valuable to allow custom dictionaries longer term. It would be great to be able to have an optional field for explanation of why a word is disallowed. I think most people understand profanity, but when we look at things like non-inclusive language, it can get more murky. I'm happy to do further PRs after this one is merged. Also happy to help maintain the project longer-term if you'd like assistance.

@nickgarlis
Copy link
Owner

@decompil3d Absolutely ! I just added you as a collaborator with push access to the repo :)

@decompil3d
Copy link
Collaborator Author

@nickgarlis Looks like you got CI working. I fixed the linter error, so all is passing now. Also, looks like CI might be trying to do deployment, but failing due to a missing env var. I assume that you don't want that to happen on branches, only on master, right?

@decompil3d
Copy link
Collaborator Author

Howdy -- it's been a while, but I was hoping to turn some attention back to this. @nickgarlis - are you still running & supporting this app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants