Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to Jest for unit tests #2422

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[x] Other... Please describe:

What is the current behavior?

Unit tests are run with a Jasmine runner

Closes #

What is the new behavior?

Unit tests and example app tests are run with Jest

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@alex-okrushko
Copy link
Member

I'm not familiar with Jest - we cannot use jasmine.createSpyObj anymore?

@brandonroberts
Copy link
Member Author

It's not supported by Jest without an additional third-party package.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I do have a questions tho.
Are we planning to run the tests with bazel in the future?
This won't cause problems with Jest, right?

@brandonroberts
Copy link
Member Author

Yes, we will still run the tests with Bazel at some point, but they are too flakey in CI (probably due to memory constraints). This shouldn't cause issues with running the tests with Bazel in the future.

@alex-okrushko alex-okrushko self-requested a review March 3, 2020 19:07
@brandonroberts brandonroberts merged commit fba0dda into master Mar 5, 2020
@brandonroberts brandonroberts deleted the jest-unit-tests branch March 5, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants