Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(store): fix flaky integration test #2209

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2184

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Nov 5, 2019

Preview docs changes for 2fef801 at https://previews.ngrx.io/pr2209-2fef801/

@brandonroberts brandonroberts merged commit 2bac73c into master Nov 5, 2019
@brandonroberts brandonroberts deleted the pr/fix-flaky-tests branch November 5, 2019 22:22
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this pull request Nov 8, 2019
refactor(effects): refactor types in effects, expose metadata key for createEffect

refactor(example): close sidenav when logoutConfirmation is dispatched (ngrx#2189)

Closes ngrx#2186

docs: remove github link from navigation (ngrx#2188)

Closes ngrx#2185

feat(schematics): add message prompts for individual schematics (ngrx#2143)

test(store): fix flaky integration test (ngrx#2209)
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] - Integration test fails intermittently
3 participants