feat(store): add ngrx-store-freeze migration #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdeschryver
commented
May 30, 2019
| }, | ||
| "ngrx-store-migration-03": { | ||
| "description": "The road to v8 RC", | ||
| "version": "8-rc.1", |
There was a problem hiding this comment.
Will this be picked up? 🤔
There was a problem hiding this comment.
This should work according to: https://github.com/angular/angular-cli/blob/master/packages/schematics/update/migrate/index_spec.ts#L133
|
Preview docs changes for a3c62bc at https://previews.ngrx.io/pr1901-a3c62bc/ |
|
|
||
| return { hit: false }; | ||
| }) | ||
| .filter(({ hit }) => hit) |
| .map(p => (p.importClause!.namedBindings! as ts.NamedImports).elements) | ||
| .reduce((imports, curr) => imports.concat(curr), [] as ts.ImportSpecifier[]) | ||
| .map(specifier => { | ||
| if (!ts.isImportSpecifier(specifier)) { |
There was a problem hiding this comment.
Is this not a duplicate of code in ast-utils.ts#L666
| return []; | ||
| } | ||
|
|
||
| const changes = imports |
There was a problem hiding this comment.
Seems totally NOT DRY; or am I mistaken?
|
Preview docs changes for 0318924 at https://previews.ngrx.io/pr1901-0318924/ |
|
Preview docs changes for 4d1128c at https://previews.ngrx.io/pr1901-4d1128c/ |
brandonroberts
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #1896
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Still to be done: