Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration for replacing ReactiveComponentModule with LetModule and PushModule on ng update #3491

Closed
markostanimirovic opened this issue Jul 15, 2022 · 2 comments · Fixed by #3506
Assignees
Labels
15.x Accepting PRs community watch Someone from the community is working this issue/PR Project: Component

Comments

@markostanimirovic
Copy link
Member

markostanimirovic commented Jul 15, 2022

Information

Add migration that replaces ReactiveComponentModule with LetModule and PushModule on ng update.

It should cover the following scenarios:

  1. Import/export in Angular module:

Before:

import { ReactiveComponentModule } from '@ngrx/component';

@NgModule({
  imports: [ReactiveComponentModule],
  exports: [ReactiveComponentModule],
})
export class TestModule {}

After:

import { LetModule, PushModule } from '@ngrx/component';

@NgModule({
  imports: [LetModule, PushModule],
  exports: [LetModule, PushModule],
})
export class TestModule {}
  1. Import in standalone component:

Before:

import { ReactiveComponentModule } from '@ngrx/component';

@Component({
  selector: 'app-test',
  standalone: true,
  imports: [ReactiveComponentModule],
})
export class TestComponent {}

After:

import { LetModule, PushModule } from '@ngrx/component';

@Component({
  selector: 'app-test',
  standalone: true,
  imports: [LetModule, PushModule],
})
export class TestComponent {}
@david-shortman
Copy link
Contributor

I'll take this!

@markostanimirovic markostanimirovic added the community watch Someone from the community is working this issue/PR label Jul 17, 2022
@markostanimirovic
Copy link
Member Author

Thanks @david-shortman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
15.x Accepting PRs community watch Someone from the community is working this issue/PR Project: Component
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants