-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schematics: add schematic for component store #2570
Comments
Wanted to grab this, but didn't find the way how to run schematics locally(not from node_modules) 😢 |
Hey @ilyaryabchinski if you want to start I can help. |
Hey @santoshyadavdev! would be nice So I am trying to run schematics directly from the repo, but get an error. What am I doing wrong? |
It's easy to write test for schematics and verify rather than trying to run it locally. You can see any existing test case. You can share the repo with me to check as well. |
As @santoshyadavdev pointed out, the easiest way to test a schematic is via unit tests. |
I am planning to look into this as there seem to be no open PR :) I have had some schematics experience |
@brandonroberts @timdeschryver and @alex-okrushko |
I am wondering if the component store should be provided for a specific component or a modal or shall we give both selections and let the user narrow down? I will base my work based off of schematics for effects, as both effects and component store are services |
@timdeschryver @brandonroberts @alex-okrushko :) any thoughts on above? |
Yes I think providing a path to a component should be an option. |
@brandonroberts Would you prefer to support two ways of providing a store: module's path and component's path or just one of them (component)? In case of component should we also always inject component store to the constructor? Do we allow to not specify neither of them and generate component store with |
Add a new schematic to generate:
A service that extends ComponentStore
A spec file if requested
Maybe an inlined interface for the default type
Describe any alternatives/workarounds you're currently using
Other information:
If accepted, I would be willing to submit a PR for this feature
[ ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
The text was updated successfully, but these errors were encountered: