Rename entity addAll to replaceAll

[elvisun]

Describe any alternatives/workarounds you're currently using

This is what addAll documentation says:

addAll: Replace current collection with provided collection

Then this really should be called replaceAll so people know their existing entities are being removed.

If accepted, I would be willing to submit a PR for this feature

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

[elvisun]

@alex-okrushko

[alex-okrushko]

Yeah, we had a case where addAll was used by accident instead of addMany and that lead to hours of debugging 😵

[alex-okrushko]

Maybe alias replaceAll to addAll and depreciate it?
removeAll can also be renamed to clearAll, but it's less error-prone, I think.

[leon-marzahn]

I don't know, i like addAll 😢 . Or at least don't use replaceAll but setAll instead, makes it easier to write 👍

[timdeschryver]

👍 for setAll if we're going to rename this.

[alex-okrushko]

@brandonroberts @MikeRyanDev any thoughts on this? It wasn't the first time 🕵️‍♀️

[brandonroberts]

Sounds good to me. Let's introduce the new one, and deprecate the old one.