Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schematics: replace styleExt with style #2248

Closed
3 tasks
timdeschryver opened this issue Nov 12, 2019 · 1 comment · Fixed by #2254
Closed
3 tasks

Schematics: replace styleExt with style #2248

timdeschryver opened this issue Nov 12, 2019 · 1 comment · Fixed by #2254
Labels
Accepting PRs Breaking Change community watch Someone from the community is working this issue/PR Comp: Docs Good First Issue Good issue for first-time contributor Project: Schematics

Comments

@timdeschryver
Copy link
Member

With the new version of the Angular CLI, the styleExt option from the schematics has been removed. Instead, a style option has been added.

We would like to keep our schematics in line with the Angular CLI schematics.

This change includes:

  • Modifying the schematic options
  • Update the schematics code
  • Uppdate the docs

For ref: angular/angular-cli@e92c46a
@Jefiozie
Copy link
Contributor

@timdeschryver going to do this one as well if you don't mind.

Jefiozie added a commit to Jefiozie/platform that referenced this issue Nov 13, 2019
@Jefiozie
refactor(schematics): migrate from styleext to style
f8af310 
Closes ngrx#2248
@Jefiozie Jefiozie mentioned this issue Nov 13, 2019
Merged
3 tasks
@timdeschryver timdeschryver added the community watch Someone from the community is working this issue/PR label Nov 13, 2019
Jefiozie added a commit to Jefiozie/platform that referenced this issue Nov 13, 2019
@Jefiozie
refactor(schematics): migrate from styleext to style
5658d74 
Closes ngrx#2248
Jefiozie added a commit to Jefiozie/platform that referenced this issue Nov 14, 2019
@Jefiozie
refactor(schematics): migrate from styleext to style
6f26dcc 
Closes ngrx#2248
Jefiozie added a commit to Jefiozie/platform that referenced this issue Nov 18, 2019
@Jefiozie
refactor(schematics): migrate from styleext to style
7110401 
Closes ngrx#2248

BREAKING CHANGES:

To be inline with the Angular CLI, we migrated the `styleExt` to `style`.

BEFORE:

```
"@schematics/angular:component": {
      "inlineStyle": true,
      "prefix": "aio",
      "styleext": "scss"
    }
...
```

AFTER:

```
"@schematics/angular:component": {
      "inlineStyle": true,
      "prefix": "aio",
      "style": "scss"
    }
....
```
brandonroberts pushed a commit that referenced this issue Jan 7, 2020
@Jefiozie @brandonroberts
refactor(schematics): migrate from styleext to style (#2254)
2801018 
Closes #2248

BREAKING CHANGES:

To be inline with the Angular CLI, the `styleExt` option has been changed to `style`.

BEFORE:

```
"@schematics/angular:component": {
      "inlineStyle": true,
      "prefix": "aio",
      "styleext": "scss"
    }
...
```

AFTER:

```
"@schematics/angular:component": {
      "inlineStyle": true,
      "prefix": "aio",
      "style": "scss"
    }
....
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs Breaking Change community watch Someone from the community is working this issue/PR Comp: Docs Good First Issue Good issue for first-time contributor Project: Schematics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(schematics): migrate from styleext to style Jefiozie/platform
2 participants
@Jefiozie @timdeschryver