feat(schematics): add x-prompt messages #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How will you get prompted for the ones with defaults? |
|
If it isn't provided, the schematic will ask for it.
If it's provided, it doesn't ask for it
|
brandonroberts
approved these changes
Nov 5, 2019
jordanpowell88
pushed a commit
to jordanpowell88/platform
that referenced
this pull request
Nov 8, 2019
refactor(effects): refactor types in effects, expose metadata key for createEffect refactor(example): close sidenav when logoutConfirmation is dispatched (ngrx#2189) Closes ngrx#2186 docs: remove github link from navigation (ngrx#2188) Closes ngrx#2185 feat(schematics): add message prompts for individual schematics (ngrx#2143) test(store): fix flaky integration test (ngrx#2209)
jordanpowell88
pushed a commit
to jordanpowell88/platform
that referenced
this pull request
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Devs need to remember the command or look in the docs to know how to use the schematics.
What is the new behavior?
This PR adds an
x-promptfor the required fields, or for the fields that I think can benefit from having anx-promptDoes this PR introduce a breaking change?
Other information
To be honest, I always forget the flags I have to pass to use the schematics.
I'm open for suggestions, if the message should be modified, or if a message needs to be added or removed.
We could also do the same for the
ng-addschematics if we agree this PR adds value.I have only tested the
storeschematics locally and I'm assuming since it worked, the rest should also work.