Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematics: Remove peer dependencies on Angular devkit #1206

Closed
brandonroberts opened this issue Jul 27, 2018 · 0 comments
Closed

Schematics: Remove peer dependencies on Angular devkit #1206

brandonroberts opened this issue Jul 27, 2018 · 0 comments

Comments

@brandonroberts
Copy link
Member

Describe any alternatives/workarounds you're currently using

Other information:

If accepted, I would be willing to submit a PR for this feature

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

There isn't a reasonable solution to this problem and it prevents us from using ng update without the --force option. We also need to come up with some integration tests that validate across different versions of the CLI schematics because. We can rely on the implicit dependencies under the assumption that if you're using our schematics, you have these libraries installed.

brandonroberts added a commit that referenced this issue Aug 1, 2018
The peer dependencies prevent you from using `ng update` since they are pinned to specific versions. We'll verify the schematics work across versions and rely on the dependencies provided implicitly with the CLI

Closes #1206
brandonroberts added a commit that referenced this issue Aug 1, 2018
The peer dependencies prevent you from using `ng update` since they are pinned to specific versions. We'll verify the schematics work across versions and rely on the dependencies provided implicitly with the CLI

Closes #1206
brandonroberts added a commit that referenced this issue Aug 1, 2018
The peer dependencies prevent you from using `ng update` since the CLI is pinned to specific versions. We'll verify the schematics work across versions and rely on the dependencies provided implicitly with the CLI

Closes #1206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant