Adds an OS X Makefile #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sminster
requested changes
Feb 23, 2018
| $(LD) $(COPTS) $(LDOPTS) $^ $(LIBS) -o $@ | ||
| @echo $(LIBRARY) | ||
| @echo $@ | ||
| $(LD) $(COPTS) $(LDOPTS) $^ $(LIBS) -o $(LIBRARY) |
There was a problem hiding this comment.
I don't think these changes are necessary.
| COPTS=-fPIC -O2 -m64 -Wall | ||
| LDOPTS=-shared -Wl,-soname,$(LIBRARY) | ||
| #CXXFLAGS=-std=c++11 | ||
| COPTS=-fPIC -O2 -m64 -Wall -std=c++11 -c |
There was a problem hiding this comment.
There shouldn't be anything in this library that requires C++11 support
There was a problem hiding this comment.
c++11 is now required by MSP, and some new features we are looking to add (supporting multiple correlation functions) want to utilized std::shared_ptr, so this will be necessary going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an OS X Makefile.
I have done this in order to support builds of the CSM via conda-forge on OS X, Linux, and Windows. This is a widely used python package management environment that supports linking Python with C (C++) languages.
I have tested this on OS X 10.12.1 by building the shared library and accessing via our CyCSM Wrapper.