fix: Replace requestIdleCallback with requestAnimationFrame for a more consistent DOM write cycle. #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 2, 2017 07:26
…e consistent DOM write cycle.
doctyper
force-pushed
the
fix/request-animation-frame
branch
from
abc8b33
to
7ba7bde
Compare
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
==========================================
- Coverage 98.96% 97.59% -1.38%
==========================================
Files 3 3
Lines 291 291
==========================================
- Hits 288 284 -4
- Misses 3 7 +4
Continue to review full report at Codecov.
|
cwelch5
approved these changes
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Chrome 60,
requestIdleCallbackis noticeably slower than previous implementations. Not sure if this is by design, but either way Helmet needs a faster DOM write cycle to avoid FOUC.