Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sample sheet tests with meta.id #761

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix sample sheet tests with meta.id #761

merged 2 commits into from
Jul 15, 2024

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented Jul 15, 2024 •
edited
Loading

During 2.9.0 the meta element was changed to contain more details.
During that procedure, the sample sheet column sampleID was added to meta.sample instead of meta.id. Some early tests and error messages were not adapted though, this is fixed here.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@d4straub d4straub mentioned this pull request Jul 15, 2024
Closed
11 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit fd106a2

+| ✅ 285 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-07-15 13:10:59

tillenglert
tillenglert approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@tillenglert tillenglert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM some already existing typos though (within comments) so really nitpicking here!

workflows/ampliseq.nf Outdated Show resolved Hide resolved
workflows/ampliseq.nf Outdated Show resolved Hide resolved
workflows/ampliseq.nf Outdated Show resolved Hide resolved
@d4straub @tillenglert
Apply suggestions from code review
fd106a2 
Co-authored-by: Till E. <64961761+tillenglert@users.noreply.github.com>
@d4straub d4straub merged commit 0fb5266 into nf-core:dev Jul 15, 2024
17 checks passed
@d4straub d4straub deleted the bug-meta.id-to-meta.sample branch July 15, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillenglert tillenglert tillenglert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d4straub @tillenglert