Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging template updates 2.4 #437

Merged
merged 6 commits into from
May 17, 2022
Merged

Merging template updates 2.4 #437

merged 6 commits into from
May 17, 2022

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented May 17, 2022 •
edited
Loading

nf-core tools template update 2.4

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented May 17, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0713d3f

+| ✅ 147 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-05-17 14:16:47

erikrikarddaniel
erikrikarddaniel approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this was just template updates, plus the changelog. Small comment in the latter, otherwise great.

CHANGELOG.md Outdated Show resolved Hide resolved
marissaDubbelaar
marissaDubbelaar approved these changes May 17, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@d4straub d4straub merged commit 953e7ad into nf-core:dev May 17, 2022
@d4straub d4straub deleted the merging-template-updates-2-4 branch May 17, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikrikarddaniel erikrikarddaniel erikrikarddaniel approved these changes

@marissaDubbelaar marissaDubbelaar marissaDubbelaar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d4straub @erikrikarddaniel @marissaDubbelaar @nf-core-bot