Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dashes in sampleID #428

Merged
merged 1 commit into from
May 12, 2022
Merged

fix dashes in sampleID #428

merged 1 commit into from
May 12, 2022

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented May 12, 2022

Fixes #423

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

nf-core lint overall result: Passed ✅

Posted for pipeline commit 47c2985

+| ✅ 146 tests passed       |+
#| ❔   1 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.3.2
  • Run at 2022-05-12 13:27:56

@d4straub
Copy link
Collaborator Author

Thanks!

@d4straub d4straub merged commit 7c1c4a6 into nf-core:dev May 12, 2022
@d4straub d4straub deleted the fix-sampleID-dash branch May 12, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants