Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fasta input #315

Merged
merged 5 commits into from
Aug 11, 2021
Merged

fix fasta input #315

merged 5 commits into from
Aug 11, 2021

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented Aug 11, 2021

Fixed fasta input and activated test_fasta that was added in #314 .

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/ampliseq/tree/master/.github/CONTRIBUTING.md)
    • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Aug 11, 2021

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 929e4ae

+| ✅ 136 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • readme - README did not have a Nextflow minimum version mentioned in Quick Start section.

✅ Tests passed:

Run details

  • nf-core/tools version 2.1
  • Run at 2021-08-11 12:32:41

Copy link
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the name of the variable, LGTM.

subworkflows/local/parse_input.nf Outdated Show resolved Hide resolved
workflows/ampliseq.nf Outdated Show resolved Hide resolved
@erikrikarddaniel erikrikarddaniel merged commit 155e0f3 into nf-core:dev Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants