-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Picrust2 #307
Add Picrust2 #307
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, just some grammar suggestions.
CITATIONS.md
Outdated
* [PICRUSt2](https://pubmed.ncbi.nlm.nih.gov/32483366/) | ||
> Douglas GM, Maffei VJ, Zaneveld JR, Yurgel SN, Brown JR, Taylor CM, Huttenhower C, Langille MGI. PICRUSt2 for prediction of metagenome functions. Nat Biotechnol. 2020 Jun;38(6):685-688. doi: 10.1038/s41587-020-0548-6. PMID: 32483366; PMCID: PMC7365738. | ||
|
||
* PICRUSt2 is using in this pipeline by default [EPA-ng](https://pubmed.ncbi.nlm.nih.gov/30165689/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar is not correct in "is using in", do you mean "is used in" or maybe "is using"? If the latter, maybe "pipeline" is not correct, maybe just "PICRUSt2 is by default using [EPA-ng]"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will change!
CITATIONS.md
Outdated
* PICRUSt2 is using in this pipeline by default [EPA-ng](https://pubmed.ncbi.nlm.nih.gov/30165689/) | ||
> Barbera P, Kozlov AM, Czech L, Morel B, Darriba D, Flouri T, Stamatakis A. EPA-ng: Massively Parallel Evolutionary Placement of Genetic Sequences. Syst Biol. 2019 Mar 1;68(2):365-369. doi: 10.1093/sysbio/syy054. PMID: 30165689; PMCID: PMC6368480. | ||
|
||
* PICRUSt2 is using in this pipeline by default [MinPath](https://pubmed.ncbi.nlm.nih.gov/19680427/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will change!
docs/output.md
Outdated
@@ -27,6 +27,7 @@ The pipeline is built using [Nextflow](https://www.nextflow.io/) and processes d | |||
* [Alpha diversity indices](#alpha-diversity-indices) - Diversity within samples | |||
* [Beta diversity indices](#beta-diversity-indices) - Diversity between samples (e.g. PCoA plots) | |||
* [ANCOM](#ancom) - Differential abundance analysis | |||
* [PICRUSt2](#picrust2) - Predicting functional abundances |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or "Predicting functional genes", "Predicting functional gene abundances"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed to "Predict the functional potential of a bacterial community"
nextflow_schema.json
Outdated
@@ -103,6 +103,10 @@ | |||
"description": "Naming of sequencing files", | |||
"help_text": "Indicates the naming of sequencing files (default: `\"/*_R{1,2}_001.fastq.gz\"`).\n\nPlease note:\n\n1. The prepended slash (`/`) is required\n2. The star (`*`) is the required wildcard for sample names\n3. The curly brackets (`{}`) enclose the orientation for paired end reads, seperated by a comma (`,`).\n4. The pattern must be enclosed in quotes\n\nFor example for one sample (name: `1`) with forward (file: `1_a.fastq.gz`) and reverse (file: `1_b.fastq.gz`) reads in folder `data`:\n\n```bash\n--input \"data\" --extension \"/*_{a,b}.fastq.gz\"\n```" | |||
}, | |||
"picrust": { | |||
"type": "boolean", | |||
"description": "If functional abundances are predicted from the marker genes." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Functional gene abundances predicted from phylogenetic relationships to marker gene organisms."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
workflows/ampliseq.nf
Outdated
@@ -520,6 +521,18 @@ workflow AMPLISEQ { | |||
} | |||
} | |||
|
|||
// | |||
// MODULE: Predict functional abundances from marker genes with Picrust2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"functional gene abundances"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
The tests fail most likely because Picrust2 needs more than the 6GB RAM that is available for ci tests. It seems that the required RAM is independent of the ASV numbers but might be due to the databases that need to be loaded. I'll keep it in the |
Den tors 29 juli 2021 kl 09:11 skrev Daniel Straub ***@***.***
:
The tests fail most likely because Picrust2 needs more than the 6GB RAM
that is available for ci tests. It seems that the required RAM is
independent of the ASV numbers but might be due to the databases that need
to be loaded. I'll keep it in the test_full profile which is executed in
AWS on demand/release, but not in test_doubleprimers.
Probably the phylogenetic placement. The reference tree is just as large no
matter the number of ASVs.
… —
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#307 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALTHQFJWORCSSOMDPJCAKTT2D5JHANCNFSM5BERUOXQ>
.
|
This solves the old issue #41
PR checklist
scrape_software_versions.py
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).