Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--max_len now accepts integers as expected #305

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented Jul 28, 2021

This solves #304

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jul 28, 2021

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d7eeb35

+| ✅ 136 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • readme - README did not have a Nextflow minimum version mentioned in Quick Start section.

✅ Tests passed:

Run details

  • nf-core/tools version 2.1
  • Run at 2021-07-28 11:01:44

Copy link
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@d4straub
Copy link
Collaborator Author

Thanks!

@d4straub d4straub merged commit e324aa7 into nf-core:dev Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants