Use modal-mask--dark selector to make icons light + add light ⬇️ dowload icon #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…load icon As of the following commit, we may use modal-mask--dark as selector to know if the modal is dark. nextcloud-libraries/nextcloud-vue@0cd2258 Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
skjnldsv
approved these changes
Nov 4, 2021
|
/backport to stable22 |
backportbot-nextcloud
bot
added
the
backport-request
|
/backport to stable21 |
|
The backport to stable21 failed. Please do this backport manually. |
backportbot-nextcloud
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a share link the download icon is rendered black instread of white
before:
after
As of the following commit, we may use
modal-mask--darkas selector to know if the modal is dark.nextcloud-libraries/nextcloud-vue@0cd2258
Steps to reproduce: