Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete button only visible on hover #848

Closed
LukasReschke opened this issue Feb 8, 2021 · 10 comments
Closed

Delete button only visible on hover #848

LukasReschke opened this issue Feb 8, 2021 · 10 comments
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working design Related to the design

Comments

@LukasReschke
Copy link
Member

Describe the bug
The delete button is only visible on hover.

To Reproduce
Steps to reproduce the behavior:

  1. Open file

Expected behavior
Delete button always visible.

Screenshots

Hover:
image

Normal:
Screenshot 2021-02-08 at 14 07 50

@juliusknorr juliusknorr transferred this issue from nextcloud/text Apr 8, 2021
@szaimen
Copy link
Contributor

szaimen commented Apr 8, 2021

@skjnldsv Maybe a fix would be to not hide the buttons at all? Would also solve the detectability issue on mobile devices...

@skjnldsv
Copy link
Member

skjnldsv commented Apr 8, 2021

Thi sis not related to the fade, but a really missing icon-delete-white :)

@skjnldsv
Copy link
Member

skjnldsv commented Apr 8, 2021

Or I misunderstood the report. If so then this is on purpose @LukasReschke

@LukasReschke
Copy link
Member Author

Thi sis not related to the fade, but a really missing icon-delete-white :)

Yep. A white one would be superb. :)

@skjnldsv skjnldsv added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working design Related to the design labels Apr 12, 2021
@skjnldsv
Copy link
Member

I guess this is fixed as there is the download button now. So the icon is always within a menu 🤔

@szaimen
Copy link
Contributor

szaimen commented Sep 1, 2021

Citing @CarlSchwan:

This seems to have already been resolved in master, but I can reproduce in stable22

image
(screenshot from master)

@mschwaig
Copy link

I assume my video here shows the same issue?
https://twitter.com/mschwaig/status/1443710487791800322

I can reproduce this on https://try.nextcloud.com as of now and wanted to report it in case that's helpful.

@jospoortvliet
Copy link
Member

I just discovered there's a download button there. And I was opening these images in a tab so I could download them 🤦

Thanks internet 👍🏻

@mschwaig
Copy link

mschwaig commented Oct 5, 2021

I assume my video here shows the same issue? https://twitter.com/mschwaig/status/1443710487791800322

I can reproduce this on https://try.nextcloud.com as of now and wanted to report it in case that's helpful.

Note that the practically invisible download button only appears when the sidebar (Participants/Details list) on the right is visible. When that's closed there is a hamburger menu with multiple options (open sidebar and download) and all of that looks fine.

@szaimen
Copy link
Contributor

szaimen commented Nov 15, 2021

Fixed in #1059

@szaimen szaimen closed this as completed Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working design Related to the design
Projects
None yet
Development

No branches or pull requests

5 participants