Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"download" icon of a photo viewer is barely visible (shared link, light theme) #28642

Closed
xalt7x opened this issue Aug 29, 2021 · 2 comments
Closed
Labels

Comments

@xalt7x
Copy link

xalt7x commented Aug 29, 2021

When you share a folder with pictures unlogged/anonymous user can open them in a viewer. On the right top corner there's three icons - "slides", "download" and "close". With a default light theme "Slides" and "Close" are in a white color but "Download" is black so it's barely visible for a user (screenshot bellow)

unlogged user menu

It's actually in a CSS

.icon-download {
    background-image: var(--icon-download-000);
}

This color is also used for hidden menu icon of a logged user

logged user menu

But shared links for anonymous user better to use different CSS

.icon-download {
   background-image: var(--icon-download-fff);
}

For now administrator can force some dark theme (e.g. "Breeze Dark") with a "Theming" app.

Steps to reproduce

  1. Share link to a folder with pictures
  2. Open new tab with that link
  3. Open any picture

Expected behaviour

All menu icons has the same color

Actual behaviour

"download" icon is black and barely visible on a dark background

Nextcloud version: 21.0.3 or 22.1.1

@xalt7x xalt7x added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Aug 29, 2021
@CarlSchwan
Copy link
Member

CarlSchwan commented Aug 30, 2021

This seems to have already been resolved in master, but I can reproduce in stable22

image (screenshot from master)

@CarlSchwan CarlSchwan removed the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Aug 30, 2021
@szaimen
Copy link
Contributor

szaimen commented Sep 1, 2021

dup of nextcloud/viewer#848

@szaimen szaimen closed this as completed Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants