Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Change icons+wording for adding text doc and folder description #5540

Merged
merged 4 commits into from
Mar 21, 2024
Merged

fix(files): Change icons+wording for adding text doc and folder description #5540

merged 4 commits into from
Mar 21, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Mar 20, 2024

This is only a partial fix so far. We'll have to wait for the icon renames in server and the introduction of icon-add-folder-description in nextcloud/server#44340.

Fixes: #5535

@mejo- mejo- added this to the Nextcloud 29 milestone Mar 20, 2024
@mejo- mejo- self-assigned this Mar 20, 2024
@mejo- mejo- mentioned this pull request Mar 20, 2024
Closed
3 tasks
@Pytal
Copy link
Member

Pytal commented Mar 20, 2024

Pushed a few updates!

Note

#969696 is used for the article svg instead of --color-text-maxcontrast to be consistent with the mimetype icons rendered in files which uses a background-image url that does not support CSS variables

@Altahrim Altahrim mentioned this pull request Mar 21, 2024
Merged
@Pytal Pytal force-pushed the fix/files_menu_icons branch 2 times, most recently from 3c28895 to 2db29d2 Compare March 21, 2024 19:21
@Pytal Pytal marked this pull request as ready for review March 21, 2024 19:21
@Pytal Pytal requested a review from juliusknorr March 21, 2024 19:21
@juliusknorr juliusknorr mentioned this pull request Mar 21, 2024
Merged
mejo- and others added 4 commits March 21, 2024 20:23
@mejo- @juliusknorr
fix(files): Change icons+wording for adding text doc and folder descr…
d4f82eb 
…iption

Fixes: #5535

Signed-off-by: Jonas <jonas@freesources.org>
@Pytal @juliusknorr
feat: Use new icon-add-folder-description
647645a 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal @juliusknorr
feat: Add icon svg inline for New text file
6814477 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal @juliusknorr
test: Update cypress selector
3c61575 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@juliusknorr
Copy link
Member

Rebased again to take the nextcloud/ocp update into account

@Pytal Pytal enabled auto-merge March 21, 2024 19:34
@Pytal Pytal merged commit 3143128 into main Mar 21, 2024
63 checks passed
@Pytal Pytal deleted the fix/files_menu_icons branch March 21, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@Pytal Pytal Pytal approved these changes

Assignees

@mejo- mejo-

Labels
3. to review
Projects
📝 Office team
Archived in project
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

Update icons in "New" menu
3 participants
@mejo- @Pytal @juliusknorr