Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mime type icons and icons in "New" menu #44340

Closed
3 tasks done
AndyScherzinger opened this issue Mar 19, 2024 · 5 comments
Closed
3 tasks done

Update mime type icons and icons in "New" menu #44340

AndyScherzinger opened this issue Mar 19, 2024 · 5 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement 🍀 2024-Spring
Milestone

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Mar 19, 2024

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

we aim to have the icons updated for v29, the remaining parts can be ignored or implemented given the 29-timebox

Before After
image image
@AndyScherzinger AndyScherzinger added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Mar 19, 2024
@AndyScherzinger AndyScherzinger added this to the Nextcloud 29 milestone Mar 19, 2024
@AndyScherzinger AndyScherzinger changed the title Update icons Update icons in "New" menu Mar 19, 2024
@susnux susnux added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Mar 19, 2024
@Pytal Pytal self-assigned this Mar 20, 2024
@jancborchardt
Copy link
Member

jancborchardt commented Mar 20, 2024

Just FYI @tobiasKaminsky @juliushaertl @sorbaugh we had to adjust the colors of 2 icons:

Text file: article in --color-text-maxcontrast

Considering this is also used in the file list and grid view (and in the widgets) and black this would be very dark then, we will keep it grey.

Diagram: drawing-box in #b39114

This fulfills the proper 3:1 contrast requirement and works in both light and dark theme.

cc @nimishavijay

@mejo-
Copy link
Member

mejo- commented Mar 20, 2024

nextcloud/text#5540 for the text side.

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Mar 20, 2024

@jancborchardt

Text file: article in --color-text-maxcontrast

Wouldn't this than also apply to the file listing, so the general mime type icon if there is no preview? And if so wouldn't this also lead to the need to adapt all "grey" mimetype icons (!) which we would want to prevent atm since that change is way larger to implement and should than be moved to v30 in my opinion. (or we just do it for the text mime type, than it would be okay)

@Pytal
Copy link
Member

Pytal commented Mar 20, 2024

@Pytal
Copy link
Member

Pytal commented Mar 20, 2024

Text file: article in --color-text-maxcontrast

Wouldn't this than also apply to the file listing, so the general mime type icon if there is no preview? And if so wouldn't this also lead to the need to adapt all "grey" mimetype icons (!) which we would want to prevent atm since that change is way larger to implement and should than be moved to v30 in my opinion. (or we just do it for the text mime type, than it would be okay)

Noticed this in the rendering of the mimetype icons (e.g. in the sidebar) which uses a background-image url and doesn't support CSS variables so I used the same grey as before #969696

@Pytal Pytal closed this as completed Mar 21, 2024
@Pytal Pytal changed the title Update icons in "New" menu Update mime type icons and icons in "New" menu Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement 🍀 2024-Spring
Projects
None yet
Development

No branches or pull requests

5 participants