Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mimetype icons #6564

Closed
AndyScherzinger opened this issue Mar 21, 2024 · 3 comments
Closed

Update mimetype icons #6564

AndyScherzinger opened this issue Mar 21, 2024 · 3 comments
Labels
design enhancement enhancement of a already implemented feature/code 🍀 2024-Spring

Comments

@AndyScherzinger
Copy link
Member

based on nextcloud/files-clients#46 (comment) and nextcloud/server#44340

@tobiasKaminsky
Copy link
Member

@allexzander @claucambra do we use them somewhere?
I assume that we use OS default ones within Windows Explorer / Finder.
And in activity stream we receive the icons from server, right?

@allexzander
Copy link
Contributor

@tobiasKaminsky

We are receiving from the server for activities (https://github.com/nextcloud/desktop/blob/master/src/gui/tray/activitydata.cpp#L184) and for VFS we also receive from the server via file preview, but yes, in the Explorer/Finder we use OS default, and I am not sure if it will be possible to replace OS default ones with custom ones (lots of work but the investigation is needed first), yet, on Windows, I assume this will break most user's expectations if Nextcloud will totally replace the default icons that are displayed by other software.

I would be glad to have a concrete example with a screenshot of where we need to replace them in the desktop client, for me to be able to have a better idea ad a more precise answer.

@AndyScherzinger
Copy link
Member Author

To be closed with "unplanned" than because there is no case to implement them except for the scenarios where this already happens being shipped by the server 👍

@AndyScherzinger AndyScherzinger closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement enhancement of a already implemented feature/code 🍀 2024-Spring
Projects
Archived in project
Development

No branches or pull requests

3 participants