-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outline view #2688
Outline view #2688
Conversation
125741a
to
fbb3dc6
Compare
This looks really great! 👏 |
Wow, this looks super nice @vinicius73 😍 How does it look like on mobile, did you find a good solution there already? Also, what happens if your window is not wide enough to display the outline? Text width is 670px, so e.g. when you're on a tablet with 800px. |
This looks awesome! 😍 One note: I think the ID generation is better suited within the Heading node, like introduced in #2520, so maybe first get the anchors?
It is possible to use it, but not that nice. It works perfect starting with ~900 - 1000px. On some other application this is solved by providing a button, something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice nice! :) Some first feedback:
- The line below "Outline" is not necessary
- The text "Outline" is a bit too present. You can reduce the size to be the same size
- The text "Outline" should be left-aligned with the h1 titles below, currently it is a bit off to the left
- Currently the outline section doesn’t seem to be vertically aligned with anything. Could you align it so that when the Text app contains normal text in the first line, the text "Outline" and that text in the first line vertically aligns?
- When clicking to navigate to a section, currently it immediately jumps. Could this be done with an ever-so-quick animation? Just like 100-250ms, so really not long, but an animation to give some feedback would be great.
- When there are no headings, I assume the whole outline box just vanishes? (Didn’t test yet)
- Possibly unrelated, but that blue border around the text content is not going to stay, right?
On some other application this is solved by providing a button, something like ➤, floating on the left side that enables some kind of drawer functionality. So the toc is faded in from the left side.
Yep, agree that would be nice. :)
fbb3dc6
to
99361e3
Compare
It is from |
Not now. The idea is to use outline to wrap "metadata" like table of contents and word counter #2664 (comment) and other possible tools. |
I agree, but unfortunately it will be a hard task for now. Can we postpone it to other issue? |
@vinicius73 this will also fix #299, right? |
And maybe also for #145 (?) |
Word count can go in the 3-dot menu as a last entry, that’s a much cleaner place for it. Let’s keep outline for outline. :)
Yes absolutely, this is not critical to this issue. |
|
It is related, but this PR no dot resolver this issues yet. |
As discussed lets keep those discussions separate and start off with the outline view only. |
d061455
to
6c96aab
Compare
Very nice, just a few additional comments from my side:
What do you think? |
/compile |
3c3364d
to
29b5ceb
Compare
Ready to review |
@vinicius73 Can you make sure every commit message has a signed off message and rebase to latest master? :) Cypress failure looked unrelated so I restarted that. |
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
29b5ceb
to
67355fb
Compare
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
When will this be available in Nextcloud? Everything is up to date on my installation. |
With nextcloud 25, scheduled for end of October (afaik) |
Summary
Add Outline view to display Table of Contents
Peek.2022-08-16.16-18.mp4