-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Show word count in RichText #2664
Conversation
4701e00
to
47dcdcc
Compare
/compile |
from #2630 (comment) @juliushaertl I'm a bit hesitant to add even more to the menu, especially on mobile. Also it is not fully related to the other actions which are more formatting actions that are targeting the current position/selection. To me it would be more suitable on the right hand side. Maybe we need to adapt the "collaborator" menu a bit to cover more details about the document in general. For reference this is how it currently looks: @jancborchardt What do you think? Dropbox Paper for example also has a separate context menu for the document itself: |
I implemented this as suggested in this comment #470 (comment) by @jancborchardt But I noticed there are quite a lot of feature requests for implementing stuff that require new buttons. Maybe this should be discussed together with: |
ceb54a9
to
d509780
Compare
/compile amend |
d509780
to
94246bb
Compare
94246bb
to
3c120c0
Compare
/compile amend |
3c120c0
to
9d9b0c9
Compare
4c591bf
to
f24b7f3
Compare
/compile amend |
f24b7f3
to
15acbf7
Compare
15acbf7
to
780f5a2
Compare
@jancborchardt affirmed this should go into the "..." menu: #2688 (comment) So I think this is ready to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Thanks for including a test.
Will give it a try and then work towards getting this merged.
UI also looks okay to me. It looks somewhat funny when it's the only entry in the three dots menu. But i guess that's okay. We'll redesign the menubar anyway. |
24f5761
to
d26ef67
Compare
d26ef67
to
297ada8
Compare
I rebased the PR to latest master and pushed a few additional changes. Hope you don't mind, @susnux. After discussing with @jancborchardt we decided (and I implemented) to:
Screenshot: |
/compile |
8a3e879
to
7b670e1
Compare
/compile |
👍 |
I agree. At the same time, |
fb1e678
to
dd24575
Compare
Yes I think this is ok, just wanted to mention this as it might be confusing. |
Thanks for continuously pushing the test fix and big sorry for overwriting it several times @susnux 😬 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
96fae8d
to
97b90b2
Compare
/rebase |
Show word count as last element of the overflow menu, which now will be always shown. The word count is updated when the menu is openend as the tiptap word count is not reactive. Modified ActionList: Added a named slot for adding elements that should always shown as the last elements. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
97b90b2
to
4ffe708
Compare
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Jonas <jonas@freesources.org>
Hi all, |
Hey @adrienneteicher. Which Nextcloud version do you use? The feature is only available starting with Nextcloud 25. |
|
Thanks Patrizio. Yes, I am on Nextcloud 24. I have to wait for my
provider to upgrade to 25.
…On 07/12/2022 12:54, Ferdinand Thiessen wrote:
|3.5.1| is the version used on Nextcloud 24. So you would have to
upgrade to Nextcloud 25 to get this feature.
—
Reply to this email directly, view it on GitHub
<#2664 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGYIPIGWVGIDTFYRKL64NDDWMB3JDANCNFSM52TAE5KQ>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Summary
Show word count as last element of the overflow menu,
which now will be always shown. The word count
is updated when the menu is openend as the
tiptap word count is not reactive.
Modified ActionList: Added a named slot for adding
elements that should always shown as the last elements.
What should be mentioned: This solution refreshes on menu open, but it is also possible to refresh it on content change.
So the current solution do not introduce many unneeded calculations, but (and I am not sure if this is even possible) does not update the label if typing while the menu is open.