Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop guest moderators when changing a conversation to group conversation #5213

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Drop guest moderators when changing a conversation to group conversation #5213

merged 1 commit into from
Feb 20, 2021

Conversation

nickvergessen
Copy link
Member

Fix #5193

@nickvergessen
Drop guest moderators when changing a conversation to group conversation
77fb711 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants labels Feb 19, 2021
@nickvergessen nickvergessen added this to the 💖 Next Major (22) milestone Feb 19, 2021
PVince81
PVince81 approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense

@PVince81 PVince81 merged commit 3a29bbc into master Feb 20, 2021
@PVince81 PVince81 deleted the bugfix/5193/also-drop-guest-moderators branch February 20, 2021 18:49
@PVince81
Copy link
Member

backports or later ?

@nickvergessen
Copy link
Member Author

/backport to stable21

@nickvergessen
Copy link
Member Author

/backport to stable21.1

@nickvergessen
Copy link
Member Author

/backport to stable20

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 20, 2021
Merged
This was referenced Feb 20, 2021
Merged
Merged
@nickvergessen
Copy link
Member Author

/backport to stable20.1

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees
No one assigned
Labels
4. to release bug feature: api 🛠️ OCS API for conversations, chats and participants
Projects
None yet
Milestone
v12.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

Changing type from public to group conversation doesn't kill guest moderators
2 participants
@nickvergessen @PVince81