Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing type from public to group conversation doesn't kill guest moderators #5193

Closed
nickvergessen opened this issue Feb 17, 2021 · 0 comments · Fixed by #5213
Closed

Changing type from public to group conversation doesn't kill guest moderators #5193

nickvergessen opened this issue Feb 17, 2021 · 0 comments · Fixed by #5213
Assignees
@nickvergessen
Labels
1. to develop bug feature: api 🛠️ OCS API for conversations, chats and participants
Milestone
v12.0.0-rc.1

Comments

@nickvergessen
Copy link
Member

spreed/lib/Room.php

Line 795 in e4556d8

->andWhere($query->expr()->in('participant_type', $query->createNamedParameter([Participant::GUEST, Participant::USER_SELF_JOINED], IQueryBuilder::PARAM_INT_ARRAY)));

Expected behaviour

Guest moderators are killed immediately

Actual behaviour

Guest moderators are missed, might break a tad later, but it should be cleaned here immediately
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickvergessen nickvergessen

Labels
1. to develop bug feature: api 🛠️ OCS API for conversations, chats and participants
Projects
None yet
Milestone
v12.0.0-rc.1
Development

Successfully merging a pull request may close this issue.

Drop guest moderators when changing a conversation to group conversation nextcloud/spreed
1 participant
@nickvergessen