Add support for opening files through viewer #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxuliu
force-pushed
the
add-support-for-opening-files-through-viewer
branch
from
e2b370f
to
140ecca
Compare
nickvergessen
added
feature: upload & shares & voice 📤🎙️
|
Wouldn't this PR fix also #1805? |
|
Well you would have to click it once, it still wouldn't play "inline" as we only show the small thumbs inline |
That is okay for me 👍 |
danxuliu
force-pushed
the
add-support-for-opening-files-through-viewer
branch
from
140ecca
to
8363053
Compare
|
I have noticed that the highlight when hovering on a file overlaps the author name (although the hovering is fine when the file is grouped with the previous message from the user, in that case there is no overlap with the previous message). However right now I can not think of a way to fix that and after all it is not something terrible, so this can be fixed later. |
|
Time to fixup 😎 |
Note that the "path" property was already being passed to FilePreview, although it was not explicitly declared. At this time the Viewer can open only internal files, which are available only for registered users. Therefore the Viewer is not loaded for guests. Also, for the time being, due to a limitation in the Viewer API, when a file is opened the Viewer allows the user to iterate through all the files in the directory of that file instead of through all the files in the conversation, as it would have been expected. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
A hover colour is shown around the file preview when hovered/focused/active in a similar way to how list items or non primary buttons are highlighted. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Like done on links, " ↗" is now added to the name of file previews to hint that the file will be opened in a different tab/window. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
add-support-for-opening-files-through-viewer
branch
from
4326dc4
to
6ab75d7
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2002
At this time the Viewer can open only internal files, which are available only for registered users. Therefore the Viewer is not loaded for guests.
Also, for the time being, due to a limitation in the Viewer API, when a file is opened the Viewer allows the user to iterate through all the files in the directory of that file instead of through all the files in the conversation, as it would have been expected.
Both issues will be solved in future releases of the viewer, so when that happens how the viewer is used will be updated in Talk.